Not signed in (Sign In)

Vanilla 1.1.9 is a product of Lussumo. More Information: Documentation, Community Support.

Welcome Guest!
Want to take part in these discussions? If you have an account, sign in now.
If you don't have an account, apply for one now.
    • CommentAuthorelarequi
    • CommentTimeMay 21st 2008
     
    I've just installed Tarski 2.1, and I've found there's some problem in navbar. Some of my static pages have titles like "Índice general" and "Estadísticas". Instead of the acute accented vowels I've got strange characters ("# Ã�ndice general" and "Estadísticas").

    I've seen in changelog that "Navbar is now added via th_header hook". Is this problem related to this change?

    As this is an unacceptable result, I've rollbacked to Tarski 2.0.5. My blog is UTF-8.
    • CommentAuthorvpetkov
    • CommentTimeMay 21st 2008
     
    same problem with me in Bulgarian.
  1.  

    It’s looks like it’s the htmlentities2() function, which encodes some characters as numeric entities (e.g. ampersands become &). See changeset r520. I’ll look into it, it shouldn’t be breaking those characters.

    I’m putting a fix into trunk and the 2.1 and 2.0 branches now, replacing htmlentities2() with the htmlspecialchars() function, which only converts characters with a special meaning in HTML. Thanks for reporting this guys, obviously a big problem for users of non-ASCII characters.

    • CommentAuthorvpetkov
    • CommentTimeMay 22nd 2008
     
    Thank you!
  2.  

    This is now fixed in the repository, see changesets r595, r596 and r597.

    I’ll probably put out a 2.1.1 release in the next few days, but until then you can apply the change yourselves very easily. Just open up the template_helper.php file and change this line in the tarski_navbar() function

    htmlentities2($page->post_title)

    to this

    htmlspecialchars($page->post_title)

    • CommentAuthorelarequi
    • CommentTimeMay 22nd 2008
     
    It works fine. Thanks, Ben.